Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932490AbbELJ2f (ORCPT ); Tue, 12 May 2015 05:28:35 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:38426 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932254AbbELJ20 (ORCPT ); Tue, 12 May 2015 05:28:26 -0400 Date: Tue, 12 May 2015 11:28:21 +0200 From: Ingo Molnar To: Matthew Garrett Cc: Matthew Garrett , x86@kernel.org, hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de, Linux Kernel Mailing List , Matthew Garrett Subject: Re: [PATCH V2] x86: Allow built-in command line to work in early kernel init Message-ID: <20150512092821.GA10900@gmail.com> References: <1428518512-13460-1-git-send-email-mjg59@coreos.com> <1428611100-23337-1-git-send-email-mjg59@srcf.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 863 Lines: 29 * Matthew Garrett wrote: > Any feedback on this? So I worry about: - the fragmented nature of it: lots of non-obvious pieces of code will now be scattered all around arch/x86/. - the crazy #ifdefs scattered around - the various pieces of data scattered around ... so while I don't mind the feature in principle, but it should be centralized much better IMHO, made Kconfig invariant at least in its fragmented callbacks, with only the very strictly boot method specific details spelled out explicitly. I have not thought much about how to achieve that :-/ Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/