Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753155AbbELJmJ (ORCPT ); Tue, 12 May 2015 05:42:09 -0400 Received: from mga11.intel.com ([192.55.52.93]:47010 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752831AbbELJmF (ORCPT ); Tue, 12 May 2015 05:42:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,414,1427785200"; d="scan'208";a="724555226" Message-ID: <5551CA21.7030001@linux.intel.com> Date: Tue, 12 May 2015 17:38:41 +0800 From: Xiao Guangrong User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Paolo Bonzini CC: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/9] KVM: MMU: introduce for_each_slot_rmap_range References: <1431397953-16642-1-git-send-email-guangrong.xiao@linux.intel.com> <1431397953-16642-4-git-send-email-guangrong.xiao@linux.intel.com> <5551B848.4090606@redhat.com> In-Reply-To: <5551B848.4090606@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1574 Lines: 58 On 05/12/2015 04:22 PM, Paolo Bonzini wrote: > > > On 12/05/2015 04:32, Xiao Guangrong wrote: >> +#define for_each_slot_rmap_range(_slot_, _start_level_, _end_level_, \ >> + _start_gfn, _end_gfn, _iter_) \ >> + for (slot_rmap_walk_init(_iter_, _slot_, _start_level_, \ >> + _end_level_, _start_gfn, _end_gfn); \ >> + slot_rmap_walk_okay(_iter_); \ >> + slot_rmap_walk_next(_iter_)) >> + > > >> + for_each_slot_rmap_range(memslot, PT_PAGE_TABLE_LEVEL, >> + PT_PAGE_TABLE_LEVEL + KVM_NR_PAGE_SIZES - 1, > > > What about adding a > > #define for PT_MAX_HUGEPAGE_LEVEL (PT_PAGE_TABLE_LEVEL + KVM_NR_PAGE_SIZES - 1) Good to me. > > ? > >> + gfn_start, gfn_end - 1, &iterator) >> + ret |= handler(kvm, iterator.rmap, memslot, >> + iterator.gfn, iterator.level, data); > > I prefer to indent by two tabs: > > for_each_slot_rmap_range(memslot, > PT_PAGE_TABLE_LEVEL, PT_MAX_HUGEPAGE_LEVEL, > gfn_start, gfn_end - 1, &iterator) > ret |= handler(kvm, iterator.rmap, memslot, > iterator.gfn, iterator.level, data); > > > Same in the next patch: > > for_each_slot_rmap_range(memslot, > start_level, end_level, > start_gfn, end_gfn, &iterator) { > if (iterator.rmap) > flush |= fn(kvm, iterator.rmap); > ... > } looks nice, will follow your style. :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/