From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: "George Spelvin" <linux@horizon.com>
Cc: joe@perches.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] lib/vsprintf.c: Further simplify uuid_string()
Organization: D03
References: <1431396840.2884.40.camel@perches.com>
	<20150512091036.5773.qmail@ns.horizon.com>
Date: Tue, 12 May 2015 13:26:50 +0200
In-Reply-To: <20150512091036.5773.qmail@ns.horizon.com> (George Spelvin's
	message of "12 May 2015 05:10:36 -0400")
Message-ID: <87vbfy6nph.fsf@rasmusvillemoes.dk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1442
Lines: 41

On Tue, May 12 2015, "George Spelvin" <linux@horizon.com> wrote:

> Make the endianness permutation table do double duty by having it
> list not source offsets, but destination offsets.  Thus, it both puts
> the bytes in the right order and skips the hyphens.
>
> This further shrinks the code from 256 to 214 bytes.  Eliminating
> erratic branches probably helps speed, too.
>
> Signed-off-by: George Spelvin <linux@horizon.com>
> ---
>> These might be better with a little comment/explanation
>> of the values as output offsets for each index.
>
> Like this?  I had thought about it, and had decied not to change the
> existing lacomic code style, as it didn't seem any harder to understand
> than the original.  But I'm happy to add comments.
>

With or without comments and the microscopic nit below:

Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

You may want/need to include Andrew Morton in the cc-list to get these
picked up.

>
>  lib/vsprintf.c | 32 ++++++++++++++------------------
>  1 file changed, 14 insertions(+), 18 deletions(-)
>
> +	/* Insert the fixed punctuation */
> +	uuid[23] = uuid[18] = uuid[13] = uuid[8] = '-';
> +	uuid[36] = 0;

I think '\0' is more common.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/