Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932493AbbELLkw (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 May 2015 07:40:52 -0400
Received: from blu004-omc1s24.hotmail.com ([65.55.116.35]:51858 "EHLO
	BLU004-OMC1S24.hotmail.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753194AbbELLkt convert rfc822-to-8bit
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 May 2015 07:40:49 -0400
X-TMN: [uklNSQLAoRIh96MxNq53snjj77T4YH77]
X-Originating-Email: [xili_gchen_5257@hotmail.com]
Message-ID: <BLU436-SMTP135C353F7438CDDA0249047B9DA0@phx.gbl>
Date: Tue, 12 May 2015 19:40:36 +0800
From: Chen Gang <xili_gchen_5257@hotmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0
MIME-Version: 1.0
To: Michael Cree <mcree@orcon.net.nz>, rth@twiddle.net,
        ink@jurassic.park.msu.ru, "mattst88@gmail.com" <mattst88@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-alpha@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] alpha: Wire up missing syscalls
References: <BLU436-SMTP115284EEDC94CD99F399465B9DD0@phx.gbl> <20150512085952.GC5711@tower>
In-Reply-To: <20150512085952.GC5711@tower>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8BIT
X-OriginalArrivalTime: 12 May 2015 11:40:47.0310 (UTC) FILETIME=[7CFD16E0:01D08CA8]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2094
Lines: 53

On 05/12/2015 04:59 PM, Michael Cree wrote:
> On Sun, May 10, 2015 at 02:33:36AM +0800, Chen Gang wrote:
>> The related warnings:
>>
>>     CALL    scripts/checksyscalls.sh
>>   <stdin>:1238:2: warning: #warning syscall seccomp not implemented [-Wcpp]
>>   <stdin>:1241:2: warning: #warning syscall getrandom not implemented [-Wcpp]
>>   <stdin>:1244:2: warning: #warning syscall memfd_create not implemented [-Wcpp]
>>   <stdin>:1247:2: warning: #warning syscall bpf not implemented [-Wcpp]
>>   <stdin>:1250:2: warning: #warning syscall execveat not implemented [-Wcpp]
> 
> Chen: Have you tested the syscalls you have wired up?
> 

Sorry, no, I didn't.

> I have a suspicion that more is required to wire up the seccomp
> syscall.  At least some of the other older architectures had to
> implement some extra arch dependent support to implement the seccomp
> syscall.  I don't know whether this is necessary or not on Alpha so
> was wondering if this has been considered?
> 

At present, I guess (I did not test), it will lead to sys_ni_call(), so
it is really only "wire up".

> Matt:  are you still feeding Alpha patches to Linus?  I suspect there
> might be a few other patches other than this one submitted to
> linux-alpha that should be applied.
> 

I found another issue when building alpha, I guess, it is valuable to be
fixed (or there was already related patch but did not submitted?):

  arch/alpha/kernel/osf_sys.c: In function ?SyS_osf_settimeofday?:
  arch/alpha/kernel/osf_sys.c:1028:14: warning: ?kts.tv_nsec? may be
used uninitialized in this function [-Wmaybe-uninitialized]
    kts.tv_nsec *= 1000;
                ^
  arch/alpha/kernel/osf_sys.c:1016:18: note: ?kts? was declared here
    struct timespec kts;
                    ^

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/