Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933357AbbELNBi (ORCPT ); Tue, 12 May 2015 09:01:38 -0400 Received: from sauhun.de ([89.238.76.85]:60551 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932314AbbELNBd (ORCPT ); Tue, 12 May 2015 09:01:33 -0400 Date: Tue, 12 May 2015 15:00:57 +0200 From: wsa@the-dreams.de To: Eddie Huang Cc: Sascha Hauer , srv_heupstream@mediatek.com, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Matthias Brugger , Jean Delvare , David Box , Doug Anderson , Zhangfei Gao , Max Schwarz , Boris BREZILLON , Anders Berg , Neelesh Gupta , Lee Jones , Arnd Bergmann , Ray Jui , Simon Glass , Wei Yan , Beniamino Galvani , Xudong Chen , Liguo Zhang , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v7 3/3] I2C: mediatek: Add driver for MediaTek MT8173 I2C controller Message-ID: <20150512130057.GC4447@schokonusskuchen.bad> References: <1430901427-65146-1-git-send-email-eddie.huang@mediatek.com> <1430901427-65146-4-git-send-email-eddie.huang@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oC1+HKm2/end4ao3" Content-Disposition: inline In-Reply-To: <1430901427-65146-4-git-send-email-eddie.huang@mediatek.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1561 Lines: 43 --oC1+HKm2/end4ao3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + if (i2c->irq_stat & I2C_RS_TRANSFER) > + dev_dbg(i2c->dev, "addr: %x, restart transfer interrupt.\n", > + msgs->addr); I'd tend to leave out this debug message. But you may leave it if you like. Rest of the patch looks okay. Thanks! --oC1+HKm2/end4ao3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJVUfmJAAoJEBQN5MwUoCm2DdoP/3ZYoROZlW7IDuykTUQw4iUl 5dalmTI1vfkGW9EUBKCda6VawpgAMCD2ZED98QLIVnAiIr9R+V5QAts55pZhCuRF DMZjUQBeyhgFg3I5WQ6tyv2BH2J1UaTgR1NASf/KNwkQPxdafmySePiSkdmKFVgv UEGPulLfpwEC2pvfwuzQKrQFawp30L5j+tYB4l169CBUIHhCE6juXIZXM5/+5fTc Iz6F+xKsoRXqZejO1r/uUs2tKruzOxwxLl91WJNJZGvccq2Ycuusw/+csxuTMzjO XEnq9DjCcy9s4rNrUdJjJlQS1T6+SJezLlj05+6N7/juto/LhrMkB4pdVTGsvsEL qLs3AjaC/MeMkIuzl/umFP4UdbwEsi0AgB0NF2o2dDEXCE5TTRMlaMXp79tCtK8s 8N/hN7W1lZvP5fgeqs79Tw8ZUfZhEw9D1KZ+frHYD5JXvET0JeFPqEhucW2hZ7rp yDl5FyZke7dkUuIs7/nBZtG7KbFeFutKkRgDXYRIhk7oURuHfkHJkLMHtdHJFOUD 9ZoaOSHGi7UGAvXoOosMGtido/tyGBmE5bOdrnbOdqhGXqDW7IqTekfuo0yyCLal YepaTyCWpYo2DiBZKYJLI7S/jtubRNJVYO3hP6BoW5n8CnsHd8B6UHU4MClwroL4 L+ymMrCbeRoT26Ct7/4u =1Pos -----END PGP SIGNATURE----- --oC1+HKm2/end4ao3-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/