Date: Tue, 12 May 2015 10:04:21 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Liang, Kan" <kan.liang@intel.com>, Ingo Molnar <mingo@kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V9 8/8] perf tools: handle PERF_RECORD_LOST_SAMPLES
Message-ID: <20150512130421.GB29215@kernel.org>
References: <1431285195-14269-1-git-send-email-kan.liang@intel.com>
 <1431285195-14269-9-git-send-email-kan.liang@intel.com>
 <20150511192225.GC5456@kernel.org>
 <37D7C6CF3E00A74B8858931C1DB2F077018263BD@SHSMSX103.ccr.corp.intel.com>
 <20150511212758.GF5456@kernel.org>
 <20150512124344.GP21418@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150512124344.GP21418@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1299
Lines: 31

Em Tue, May 12, 2015 at 02:43:44PM +0200, Peter Zijlstra escreveu:
> On Mon, May 11, 2015 at 06:27:58PM -0300, Arnaldo Carvalho de Melo wrote:
> > I disagree, since the support is there, we need to have it in
> > hists->events_stats[PERF_RECORD_LOST_SAMPLES].

> > But that can be done in a follow up patch.

> Agreed, it would be good to know of which event the samples got lost.

> > It just came quickly to my attention because of all the discussion about
> > where to store something (PERF_SAMPLE_ID via sample_type + sample_id_all)
> > that doesn't get used in the patch that introduces it :-)
> > 
> > I'll try to test this all tomorrow and will try to do the needed wiring
> > to hists_evsel->hists->events_stats.
> > 
> > All working I can push this all via my perf/core event, if PeterZ
> > agrees and is ok with the kernel specific bits.
> 
> I would like to carry these as there some conflicts with other patches I
> have.

So go ahead and do it, when it lands on tip I'll check and try to
continue what was discussed here, thanks!

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/