Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933173AbbELN0p (ORCPT ); Tue, 12 May 2015 09:26:45 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:55971 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932892AbbELN0j (ORCPT ); Tue, 12 May 2015 09:26:39 -0400 Date: Tue, 12 May 2015 15:26:34 +0200 From: Sascha Hauer To: Paul Bolle Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Kevin Hilman , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, kernel@pengutronix.de, Matthias Brugger Subject: Re: [PATCH 1/5] soc: mediatek: Add infracfg misc driver support Message-ID: <20150512132634.GV6325@pengutronix.de> References: <1431372206-1237-1-git-send-email-s.hauer@pengutronix.de> <1431372206-1237-2-git-send-email-s.hauer@pengutronix.de> <1431422671.2398.155.camel@x220> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431422671.2398.155.camel@x220> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:24:43 up 57 days, 1:16, 95 users, load average: 0.04, 0.16, 0.14 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2083 Lines: 53 Hi Paul, On Tue, May 12, 2015 at 11:24:31AM +0200, Paul Bolle wrote: > On Mon, 2015-05-11 at 21:23 +0200, Sascha Hauer wrote: > > --- a/drivers/soc/mediatek/Kconfig > > +++ b/drivers/soc/mediatek/Kconfig > > > +config MTK_INFRACFG > > + tristate "MediaTek INFRACFG Support" > > + depends on ARCH_MEDIATEK > > + select REGMAP > > + help > > + Say yes here to add support for the MediaTek INFRACFG controller. The > > + INFRACFG controller contains various infrastructure registers not > > + directly associated to any device. > > > --- a/drivers/soc/mediatek/Makefile > > +++ b/drivers/soc/mediatek/Makefile > > > +obj-$(CONFIG_MTK_INFRACFG) += mtk-infracfg.o > > > --- /dev/null > > +++ b/drivers/soc/mediatek/mtk-infracfg.c > > > +EXPORT_SYMBOL_GPL(mtk_infracfg_set_bus_protection); > > > +EXPORT_SYMBOL_GPL(mtk_infracfg_clear_bus_protection); > > As I understand it, if both MTK_INFRACFG and MTK_SCPSYS (see 3/5) are m > we will get mtk-infracfg.ko and mtk-scpsys.ko (see 3/5). And loading > mtk-scpsys.ko will trigger loading mtk-infracfg.ko, right? > > But since this file has no MODULE_LICENSE() that should generate a > warning and taint the kernel. (I haven't tested this. Please correct me > if I'm overlooking something here.) No, you're absolutely right here. It turned out though that the power domain specific functions are not exported to modules and also there is no unregistration code for power domains, so compiling this code as modules doesn't work anyway. I'll change the tristate to bool. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/