Date: 12 May 2015 09:57:36 -0400
Message-ID: <20150512135736.7868.qmail@ns.horizon.com>
From: "George Spelvin" <linux@horizon.com>
To: linux@horizon.com, linux@rasmusvillemoes.dk
Subject: Re: [PATCH 2/2 v2] lib/vsprintf.c: Further simplify uuid_string()
Cc: joe@perches.com, linux-kernel@vger.kernel.org
In-Reply-To: <87vbfy6nph.fsf@rasmusvillemoes.dk>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 771
Lines: 25

> Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> 
> You may want/need to include Andrew Morton in the cc-list to get these
> picked up.

Thank you; I sent it to you because I'm not sure who's really in charge
of this.

>> +	/* Insert the fixed punctuation */
>> +	uuid[23] = uuid[18] = uuid[13] = uuid[8] = '-';
>> +	uuid[36] = 0;

> I think '\0' is more common.

It's that way beause of it was replacing

>> -	*p = 0;

But yes, I prefer the char constant, too.  And it would be consistent with
the rest of the file.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/