Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932923AbbELOa0 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 May 2015 10:30:26 -0400
Received: from arcturus.aphlor.org ([188.246.204.175]:35669 "EHLO
	arcturus.aphlor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932632AbbELOaG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 May 2015 10:30:06 -0400
Date: Tue, 12 May 2015 10:29:42 -0400
From: Dave Jones <davej@codemonkey.org.uk>
To: Michael Cree <mcree@orcon.net.nz>, Chen Gang <xili_gchen_5257@hotmail.com>,
        rth@twiddle.net, ink@jurassic.park.msu.ru,
        "mattst88@gmail.com" <mattst88@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-alpha@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] alpha: Wire up missing syscalls
Message-ID: <20150512142942.GA12264@codemonkey.org.uk>
Mail-Followup-To: Dave Jones <davej@codemonkey.org.uk>,
	Michael Cree <mcree@orcon.net.nz>,
	Chen Gang <xili_gchen_5257@hotmail.com>, rth@twiddle.net,
	ink@jurassic.park.msu.ru, "mattst88@gmail.com" <mattst88@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-alpha@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <BLU436-SMTP115284EEDC94CD99F399465B9DD0@phx.gbl>
 <20150512085952.GC5711@tower>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150512085952.GC5711@tower>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Report: Spam report generated by SpamAssassin on "arcturus.aphlor.org"
 Content analysis details:   (-2.9 points, 5.0 required)
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
                             [score: 0.0000]
X-Authenticated-User: davej@codemonkey.org.uk
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1355
Lines: 30

On Tue, May 12, 2015 at 08:59:52PM +1200, Michael Cree wrote:
 > On Sun, May 10, 2015 at 02:33:36AM +0800, Chen Gang wrote:
 > > The related warnings:
 > > 
 > >     CALL    scripts/checksyscalls.sh
 > >   <stdin>:1238:2: warning: #warning syscall seccomp not implemented [-Wcpp]
 > >   <stdin>:1241:2: warning: #warning syscall getrandom not implemented [-Wcpp]
 > >   <stdin>:1244:2: warning: #warning syscall memfd_create not implemented [-Wcpp]
 > >   <stdin>:1247:2: warning: #warning syscall bpf not implemented [-Wcpp]
 > >   <stdin>:1250:2: warning: #warning syscall execveat not implemented [-Wcpp]
 > 
 > Chen: Have you tested the syscalls you have wired up?
 > 
 > I have a suspicion that more is required to wire up the seccomp
 > syscall.

likewise sys_bpf judging by the absence of bpf_int_jit_compile and friends in arch/alpha
The weak symbols mean it probably compiles/links, but it doesn't actually do
anything, and now instead of -ENOSYS, anyone trying to actually use that syscall
on alpha will get weird results.

Shutting up warnings like this strikes me as the wrong thing to do.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/