Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933022AbbELOeU (ORCPT ); Tue, 12 May 2015 10:34:20 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:36863 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932790AbbELOeS (ORCPT ); Tue, 12 May 2015 10:34:18 -0400 MIME-Version: 1.0 In-Reply-To: <20150512133202.GA24684@ulmo.nvidia.com> References: <1431336382-13167-1-git-send-email-yh.huang@mediatek.com> <1431336382-13167-3-git-send-email-yh.huang@mediatek.com> <20150512133202.GA24684@ulmo.nvidia.com> Date: Tue, 12 May 2015 16:34:16 +0200 Message-ID: Subject: Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support From: Matthias Brugger To: Thierry Reding Cc: YH Huang , Mark Rutland , Rob Herring , Pawel Moll , linux-pwm@vger.kernel.org, "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , srv_heupstream , linux-mediatek@lists.infradead.org, Sascha Hauer Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2118 Lines: 60 2015-05-12 15:32 GMT+02:00 Thierry Reding : > On Mon, May 11, 2015 at 05:26:22PM +0800, YH Huang wrote: >> Add display PWM driver support to modify backlight for MT8173/MT6595. >> >> Signed-off-by: YH Huang >> --- >> drivers/pwm/Kconfig | 9 ++ >> drivers/pwm/Makefile | 1 + >> drivers/pwm/pwm-disp-mediatek.c | 225 ++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 235 insertions(+) >> create mode 100644 drivers/pwm/pwm-disp-mediatek.c >> >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig >> index b1541f4..9edbb5a 100644 >> --- a/drivers/pwm/Kconfig >> +++ b/drivers/pwm/Kconfig >> @@ -111,6 +111,15 @@ config PWM_CLPS711X >> To compile this driver as a module, choose M here: the module >> will be called pwm-clps711x. >> >> +config PWM_DISP_MEDIATEK > > Please make this "PWM_MEDIATEK_DISP" so we can keep everything sorted by > vendor. > >> + tristate "MEDIATEK display PWM driver" > > "MediaTek"? > >> + depends on OF > > Technically I think you need depends on HAS_IOMEM here to avoid breakage > on randconfig builds. > >> + help >> + Generic PWM framework driver for mediatek disp-pwm device. > > "MediaTek"? Also perhaps this should describe what this PWM is instead > of just the "disp-pwm" which leaves everyone guessing what it is. From > the name I'd expect it to be the PWM that is used to control the > backlight brightness for display, but I think this description should > say that explicitly. > >> + >> + To compile this driver as a module, choose M here: the module >> + will be called pwm-disp-mediatek. > > pwm-mediatek-disp I would prefert pwm-mtk-disp which is in line with the other drivers. Also I have to admit that unfortunately the naming is not uniformly throughout the kernel. Thanks, Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/