Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933071AbbELOjt (ORCPT ); Tue, 12 May 2015 10:39:49 -0400 Received: from www.linutronix.de ([62.245.132.108]:55607 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932473AbbELOjp (ORCPT ); Tue, 12 May 2015 10:39:45 -0400 Date: Tue, 12 May 2015 16:39:57 +0200 (CEST) From: Thomas Gleixner To: Baolin Wang cc: Arnd Bergmann , linux-kernel@vger.kernel.org, y2038 Mailman List Subject: Re: [PATCH v3 05/22] posix-timers:Convert to the 64bit methods for the timer_gettime syscall function In-Reply-To: Message-ID: References: <1431342914-29569-1-git-send-email-baolin.wang@linaro.org> <3090730.Lc4aTu6C4b@wuerfel> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1179 Lines: 34 On Tue, 12 May 2015, Baolin Wang wrote: > On 12 May 2015 at 00:30, Arnd Bergmann wrote: > > > On Monday 11 May 2015 19:15:14 Baolin Wang wrote: > > > +static int default_timer_get64(struct k_itimer *timr, > > > + struct itimerspec64 *cur_setting64) > > > +{ > > > + struct itimerspec cur_setting; > > > + struct k_clock *kc = clockid_to_kclock(timr->it_clock); > > > + > > > + kc->timer_get(timr, &cur_setting); > > > + return 0; > > > +} > > > > This function is unfortunately incorrect, because you never copy > > the cur_setting value into cur_setting64. > > Thanks for your comments. But i think this is just a temporary > default function, and will be removed after all the drivers' > conversion, so just ensure it won't cause the kernel crash. The function is crap no matter whether its removed later or not. And it breaks bisectability. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/