Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933330AbbELOvk (ORCPT ); Tue, 12 May 2015 10:51:40 -0400 Received: from www.linutronix.de ([62.245.132.108]:55709 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbbELOvg (ORCPT ); Tue, 12 May 2015 10:51:36 -0400 Date: Tue, 12 May 2015 16:51:48 +0200 (CEST) From: Thomas Gleixner To: Baolin Wang cc: arnd@arndb.de, linux-kernel@vger.kernel.org, y2038@lists.linaro.org Subject: Re: [PATCH v3 09/22] posix-timers:Convert to the 64bit methods for the clock_settime syscall function In-Reply-To: <1431342991-29721-1-git-send-email-baolin.wang@linaro.org> Message-ID: References: <1431342991-29721-1-git-send-email-baolin.wang@linaro.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 591 Lines: 19 On Mon, 11 May 2015, Baolin Wang wrote: > +static int default_clock_set64(const clockid_t which_clock, > + const struct timespec64 *tp64) > +{ > + struct k_clock *kc = clockid_to_kclock(which_clock); > + struct timespec tp; > + > + kc->clock_set(which_clock, &tp); So you set the clock from an unitialized variable..... Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/