From: Arnd Bergmann <arnd@arndb.de>
To: y2038@lists.linaro.org
Cc: Baolin Wang <baolin.wang@linaro.org>, tglx@linutronix.de,
        linux-kernel@vger.kernel.org
Subject: Re: [Y2038] [PATCH v3 08/23] posix-timers:Convert to the 64bit methods for the timer_settime syscall function
Date: Tue, 12 May 2015 17:36:38 +0200
Message-ID: <2196679.VURrorBePj@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1431439814-28820-1-git-send-email-baolin.wang@linaro.org>
References: <1431439814-28820-1-git-send-email-baolin.wang@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1192
Lines: 29

On Tuesday 12 May 2015 22:10:14 Baolin Wang wrote:
> +static int default_timer_set64(struct k_itimer *timr, int flags,
> +                              struct itimerspec64 *new_setting64,
> +                              struct itimerspec64 *old_setting64)
> +{
> +       struct k_clock *kc = clockid_to_kclock(timr->it_clock);
> +       struct itimerspec new_setting, old_setting;
> +       int ret;
> +
> +       new_setting = itimerspec64_to_itimerspec(new_setting64);
> +       old_setting = itimerspec64_to_itimerspec(old_setting64);
> +       ret = kc->timer_set(timr, flags, &new_setting, &old_setting);
> +       if (!ret && old_setting64)
> +               *old_setting64 = itimerspec_to_itimerspec64(&old_setting);
> +
> +       return ret;
> +}
> 

You check old_setting64 for a NULL pointer in the second access, but not
in the first one, which is a bug. Please also check whether the variable
is used as input, output or both.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/