Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933334AbbELPyh (ORCPT ); Tue, 12 May 2015 11:54:37 -0400 Received: from down.free-electrons.com ([37.187.137.238]:58159 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932892AbbELPyf (ORCPT ); Tue, 12 May 2015 11:54:35 -0400 Date: Tue, 12 May 2015 17:54:31 +0200 From: Thomas Petazzoni To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Maxime Ripard , Vinod Koul , Dan Williams , Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Lior Amsalem , Herbert Xu , Thomas Petazzoni , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH 2/8] dmaengine: mv_xor: add support for a38x command in descriptor mode Message-ID: <20150512175431.378c346e@free-electrons.com> In-Reply-To: <4862159.g8Sk9nOiS2@wuerfel> References: <1431445063-20226-1-git-send-email-maxime.ripard@free-electrons.com> <1431445063-20226-3-git-send-email-maxime.ripard@free-electrons.com> <4862159.g8Sk9nOiS2@wuerfel> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 964 Lines: 30 Dear Arnd Bergmann, On Tue, 12 May 2015 17:49:08 +0200, Arnd Bergmann wrote: > Using > > if (IS_ENABLED(__BIG_ENDIAN)) > > here would make it more readable by avoiding the #if. Alternatively, > you could leave the XOR_DESCRIPTOR_SWAP flag disabled and just swap > the descriptors manually like a lot of other drivers do. You have > to swap the mmio accesses anywya. Agreed on IS_ENABLED(). However, I don't understand the comment about the need to swap mmio accesses? We're using readl_relaxed() / writel_relaxed(), and they do the swapping already. Am I missing something? Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/