Message-ID: <5552231A.9010503@tronnes.org>
Date: Tue, 12 May 2015 17:58:18 +0200
From: =?UTF-8?B?Tm9yYWxmIFRyw7hubmVz?= <noralf@tronnes.org>
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: dmaengine@vger.kernel.org, vinod.koul@intel.com,
        Stephen Warren <swarren@wwwdotorg.org>, Lee Jones <lee@kernel.org>
CC: linux-kernel@vger.kernel.org, jonathan@raspberrypi.org,
        linux-rpi-kernel@lists.infradead.org, dan.j.williams@intel.com
Subject: Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support
References: <1429355160-13657-1-git-send-email-noralf@tronnes.org>
In-Reply-To: <1429355160-13657-1-git-send-email-noralf@tronnes.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1559
Lines: 50

Hi,

Den 18.04.2015 13:06, skrev Noralf Trønnes:
> Add slave transfer capability to BCM2835 dmaengine driver.
> This patch is pulled from the bcm2708-dmaengine driver in the
> Raspberry Pi repo. The work was done by Gellert Weisz.
>
> Tested using the bcm2835-mmc driver from the same repo.
>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> ---
>
> Gellert Weisz has ended his internship with Raspberry Pi Trading and
> was not available to sign off this patch.
>
> The patch is made against mainline 4.0-rc7.
>
> Changes from v1:
> 	Martin Sperl, Dom Cobley:
> 	MAX_LITE_TRANSFER has to be 32-bit aligned
>
> 	Stefan Wahren:
> 	Variable es is not used
> 	Change splitct to split_cnt
> 	Add dev_err for unsupported buswidth
> 	Rearrange d->frames formula for readability
> 	Move j variable definition to loop
>
> Changes from original code:
> 	Remove slave_id use.
> 	SDHCI_BCM_DMA_WAITS changed to BCM2835_DMA_WAIT_CYCLES.
> 	Use SZ_* macros instead of decimal values.
> 	Change MAX_LITE_TRANSFER from 32k to 64K - 1.
> 	Fix several whitespace issues.
>
> 	Lee Jones' comments in previous email to Piotr Król:
> 	Remove __func__ from dev_err message.
> 	Cleanup comments.

Is there something missing for this patch to get accepted?
spi-bcm2835 has now DMA support that depends on this patch.


Noralf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/