Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933653AbbELQKz (ORCPT ); Tue, 12 May 2015 12:10:55 -0400 Received: from mga11.intel.com ([192.55.52.93]:21033 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753528AbbELQKw (ORCPT ); Tue, 12 May 2015 12:10:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,416,1427785200"; d="scan'208";a="727967636" User-Agent: Microsoft-MacOutlook/14.4.8.150116 Date: Tue, 12 May 2015 09:10:49 -0700 Subject: Re: [PATCH 1/5] selftests: Add futex functional tests From: Darren Hart To: Cyril Hrubis CC: Shuah Khan , , Linux Kernel Mailing List , John Stultz , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Davidlohr Bueso , KOSAKI Motohiro Message-ID: Thread-Topic: [PATCH 1/5] selftests: Add futex functional tests References: <57d921b1c30e8258ca4b2f55637424527317e92f.1431121818.git.dvhart@linux.intel.com> <5550EF8D.8080403@osg.samsung.com> <5550FB2C.1000403@osg.samsung.com> <5551164E.5080409@osg.samsung.com> <55512B54.50304@osg.samsung.com> <55512B86.2040900@osg.samsung.com> <20150512100256.GA5122@rei.suse.de> In-Reply-To: <20150512100256.GA5122@rei.suse.de> Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1230 Lines: 36 On 5/12/15, 3:02 AM, "Cyril Hrubis" wrote: >Hi! >> I'm happy to do that, but I would like to make sure I'm doing the right >> thing. > >The right thing here is to add -pthread to CFLAGS which sets both flags >for preprocessor and linker (see man gcc). Hi Cyril, Thanks. I read that, and mentioned it, but my concern with -pthread in the CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I understand we have a number of gcc-isms in our build - but do we want to add more? I'm also struggling to find any kind of prescribed documentation on this beyond the short blurb in the gcc man page which describes what this option does, but not when to use it. I'll need something concrete to justify changes to testcase Makefiles to Shuah. Unfortunately, all these options are functional for me, while some are not for Shuah, so I'm currently having to rely on documentation which seems pretty sparse. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/