Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932938AbbELQO3 (ORCPT ); Tue, 12 May 2015 12:14:29 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:34865 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753322AbbELQO1 (ORCPT ); Tue, 12 May 2015 12:14:27 -0400 MIME-Version: 1.0 In-Reply-To: <1431427815.28073.53.camel@linux.intel.com> References: <1431418137-32320-1-git-send-email-kuleshovmail@gmail.com> <1431418183-1440-1-git-send-email-kuleshovmail@gmail.com> <1431427815.28073.53.camel@linux.intel.com> Date: Tue, 12 May 2015 22:14:27 +0600 Message-ID: Subject: Re: [PATCH v3 1/3] x86/setup: introduce setup_bultin_cmdline From: Alexander Kuleshov To: Andy Shevchenko Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , LKML , Greg Kroah-Hartman , Borislav Petkov , Mark Rustad , Yinghai Lu Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 646 Lines: 20 Hi Andy, 2015-05-12 16:50 GMT+06:00 Andy Shevchenko : > > This one breaks kernel to work. You have to call setup_builtin_cmdline() > here. > >> strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE); >> *cmdline_p = command_line; >> Why? The setup_builtin_cmdline will be called before setup_arch in the head{32, 64}.c, or I've missed something? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/