Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753406AbbELQrW (ORCPT ); Tue, 12 May 2015 12:47:22 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54063 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbbELQrR (ORCPT ); Tue, 12 May 2015 12:47:17 -0400 Message-ID: <55522E92.8090609@osg.samsung.com> Date: Tue, 12 May 2015 10:47:14 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Darren Hart , Cyril Hrubis CC: linux-api@vger.kernel.org, Linux Kernel Mailing List , John Stultz , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Davidlohr Bueso , KOSAKI Motohiro , Shuah Khan Subject: Re: [PATCH 1/5] selftests: Add futex functional tests References: <57d921b1c30e8258ca4b2f55637424527317e92f.1431121818.git.dvhart@linux.intel.com> <5550EF8D.8080403@osg.samsung.com> <5550FB2C.1000403@osg.samsung.com> <5551164E.5080409@osg.samsung.com> <55512B54.50304@osg.samsung.com> <55512B86.2040900@osg.samsung.com> <20150512100256.GA5122@rei.suse.de> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1687 Lines: 48 On 05/12/2015 10:10 AM, Darren Hart wrote: > On 5/12/15, 3:02 AM, "Cyril Hrubis" wrote: > >> Hi! >>> I'm happy to do that, but I would like to make sure I'm doing the right >>> thing. >> >> The right thing here is to add -pthread to CFLAGS which sets both flags >> for preprocessor and linker (see man gcc). > > Hi Cyril, > > Thanks. I read that, and mentioned it, but my concern with -pthread in the > CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I > understand we have a number of gcc-isms in our build - but do we want to > add more? > > I'm also struggling to find any kind of prescribed documentation on this > beyond the short blurb in the gcc man page which describes what this > option does, but not when to use it. I'll need something concrete to > justify changes to testcase Makefiles to Shuah. > > Unfortunately, all these options are functional for me, while some are not > for Shuah, so I'm currently having to rely on documentation which seems > pretty sparse. > Hi Daren, My goals are really simple. make kselftest doesn't break. All tests compile and run and install or fail gracefully when dependencies aren't met. As long as the above are met, I don't really worry about what individual test Makefiles do. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/