Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933779AbbELRc2 (ORCPT ); Tue, 12 May 2015 13:32:28 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:19969 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932776AbbELR0R (ORCPT ); Tue, 12 May 2015 13:26:17 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 12 May 2015 10:24:35 -0700 From: Rhyland Klein To: Peter De Schrijver CC: Mike Turquette , Stephen Warren , Stephen Boyd , Thierry Reding , Alexandre Courbot , Bill Huang , Paul Walmsley , Jim Lin , Benson Leung , linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Rhyland Klein Subject: [PATCH v5 06/21] clk: tegra: pll: update warning msg Date: Tue, 12 May 2015 13:23:49 -0400 Message-ID: <1431451444-23155-8-git-send-email-rklein@nvidia.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1431451444-23155-1-git-send-email-rklein@nvidia.com> References: <1431451444-23155-1-git-send-email-rklein@nvidia.com> X-NVConfidentiality: public MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 31 Swap out the generic WARN_ON with a WARN which gives more information about what is happening. Reviewed-by: Benson Leung Signed-off-by: Rhyland Klein --- drivers/clk/tegra/clk-pll.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c index 1e1018dd466f..0282d9f4f2d7 100644 --- a/drivers/clk/tegra/clk-pll.c +++ b/drivers/clk/tegra/clk-pll.c @@ -692,7 +692,8 @@ static unsigned long clk_pll_recalc_rate(struct clk_hw *hw, pdiv = _hw_to_p_div(hw, cfg.p); if (pdiv < 0) { - WARN_ON(1); + WARN(1, "Clock %s has invalid pdiv value : 0x%x\n", + __clk_get_name(hw->clk), cfg.p); pdiv = 1; } -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/