Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933599AbbELRwj (ORCPT ); Tue, 12 May 2015 13:52:39 -0400 Received: from mga09.intel.com ([134.134.136.24]:11185 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932998AbbELRwi (ORCPT ); Tue, 12 May 2015 13:52:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,416,1427785200"; d="scan'208";a="492689954" Message-ID: <1431453133.28073.66.camel@linux.intel.com> Subject: Re: [PATCH v3 1/3] x86/setup: introduce setup_bultin_cmdline From: Andy Shevchenko To: Alexander Kuleshov Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , LKML , Greg Kroah-Hartman , Borislav Petkov , Mark Rustad , Yinghai Lu Date: Tue, 12 May 2015 20:52:13 +0300 In-Reply-To: References: <1431418137-32320-1-git-send-email-kuleshovmail@gmail.com> <1431418183-1440-1-git-send-email-kuleshovmail@gmail.com> <1431427815.28073.53.camel@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1080 Lines: 33 On Tue, 2015-05-12 at 22:14 +0600, Alexander Kuleshov wrote: > Hi Andy, > > > 2015-05-12 16:50 GMT+06:00 Andy Shevchenko : > > > > This one breaks kernel to work. You have to call setup_builtin_cmdline() > > here. > > > >> strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE); > >> *cmdline_p = command_line; > >> > > Why? The setup_builtin_cmdline will be called before setup_arch in the > head{32, 64}.c, > or I've missed something? Yes, you missed the call here in *this* patch. So, here is a trade off between smaller understandable changes and bisectability. On one hand you may go like you did previously (one patch for two changes), on the other — make it work after each patch applied one-by-one. -- Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/