Message-ID: <555259E1.8010908@gmail.com>
Date: Tue, 12 May 2015 21:52:01 +0200
From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Greg KH <gregkh@linuxfoundation.org>
CC: dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 02/33] staging: rtl8192e: Fix PREFER_ETHER_ADDR_COPY
 warnings
References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com> <1431206361-13736-3-git-send-email-mateusz.kulikowski@gmail.com> <20150510131955.GA10427@kroah.com>
In-Reply-To: <20150510131955.GA10427@kroah.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 950
Lines: 28

On 10.05.2015 15:19, Greg KH wrote:
> On Sat, May 09, 2015 at 11:18:50PM +0200, Mateusz Kulikowski wrote:
>> Replace memcpy() with ether_addr_copy() where possible to make
>> checkpatch.pl happy.
> 
> I need proof that this is ok to do, please provide that in the changelog
> entry.

What kind of proof do you expect?

I've added BUG into ether_addr_copy (on unaligned addresses) and did some basic 
networking tests (pings using WPA2/CCMP AP). Of course I haven't done 100% coverage 
test to driver.

Additionally I manually analyzed code (although human errors are possible).

Do you want me to run some static analyzer as well? Or are this two enough 
(just add them to changelog).


Regards,
Mateusz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/