Message-ID: <1431460414.2884.89.camel@perches.com>
Subject: Re: [PATCH v3 01/33] staging: rtl8192e: Declare ethernet addresses
 as __aligned(2)
From: Joe Perches <joe@perches.com>
To: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Cc: gregkh@linuxfoundation.org, dan.carpenter@oracle.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Tue, 12 May 2015 12:53:34 -0700
In-Reply-To: <55525805.50807@gmail.com>
References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com>
	 <1431206361-13736-2-git-send-email-mateusz.kulikowski@gmail.com>
	 <1431210572.22450.78.camel@perches.com> <55525805.50807@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1480
Lines: 37

On Tue, 2015-05-12 at 21:44 +0200, Mateusz Kulikowski wrote:
> On 10.05.2015 00:29, Joe Perches wrote:
> > On Sat, 2015-05-09 at 23:18 +0200, Mateusz Kulikowski wrote:
> >> Add __aligned(2) into ethernet addresses allocated on stack or in non-packed
> >> structures. Use ETH_ALEN as array length in places where it was hardcoded to 6.
> > []
> >> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> > []
> >> @@ -321,7 +321,8 @@ static void rtl8192_read_eeprom_info(struct net_device *dev)
> >>  	u8 ICVer8192, ICVer8256;
> >>  	u16 i, usValue, IC_Version;
> >>  	u16 EEPROMId;
> >> -	u8 bMac_Tmp_Addr[6] = {0x00, 0xe0, 0x4c, 0x00, 0x00, 0x01};
> >> +	u8 bMac_Tmp_Addr[ETH_ALEN] __aligned(2) = {0x00, 0xe0, 0x4c,
> >> +						   0x00, 0x00, 0x01};
> > 
> > While this is safe, as this follows a u16, it's unnecessary.
> > 
> > Also, ideally, this would be
> > 	u8 foo[ETH_ALEN] = {
> > 		1, 2, 3, 4, 5, 6
> > 	};
> > or just left on a single line.
> 
> I put __aligned to most places to show authors intention and to prevent someone from breaking it by 
> (for example) removing u16 above due some refactoring.
> 
> If you insist - I will remove it.

I'm not very insistent.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/