Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933880AbbELUF5 (ORCPT ); Tue, 12 May 2015 16:05:57 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:34396 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771AbbELUFx (ORCPT ); Tue, 12 May 2015 16:05:53 -0400 Message-ID: <55525D1D.5020104@gmail.com> Date: Tue, 12 May 2015 22:05:49 +0200 From: Mateusz Kulikowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Greg KH CC: devel@driverdev.osuosl.org, dan.carpenter@oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy() References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com> <1431206361-13736-4-git-send-email-mateusz.kulikowski@gmail.com> <20150510132035.GB10427@kroah.com> In-Reply-To: <20150510132035.GB10427@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 26 On 10.05.2015 15:20, Greg KH wrote: > On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote: >> Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY >> checkpatch.pl warning. >> It will prevent accidential "Fix" to ether_addr_copy(). > > What do you mean by this? Why will the comment remove the issue? > It will not, It will prevent people from sending checkpatch 'fixes' until I (or someone else) will submit ultimate fix - that is ether_addr_copy_unaligned(). I didn't included it into this series, as this requires cross-tree synchronization (net + staging) and I prefer to do it later in a smaller changeset (2 patches - one for net, one for staging). If you think it's unnecessary, I'll throw it away in v4. Regards, Mateusz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/