Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753981AbbELUII (ORCPT ); Tue, 12 May 2015 16:08:08 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:35483 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752614AbbELUIE (ORCPT ); Tue, 12 May 2015 16:08:04 -0400 Message-ID: <55525DA1.5010701@gmail.com> Date: Tue, 12 May 2015 22:08:01 +0200 From: Mateusz Kulikowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Dan Carpenter CC: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 28/33] staging: rtl8192e: Replace ?: with max References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com> <1431206361-13736-29-git-send-email-mateusz.kulikowski@gmail.com> <20150511132246.GL14154@mwanda> In-Reply-To: <20150511132246.GL14154@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 23 On 11.05.2015 15:22, Dan Carpenter wrote: > On Sat, May 09, 2015 at 11:19:16PM +0200, Mateusz Kulikowski wrote: (...) >> len = crypt->ops->get_key(keybuf, SCM_KEY_LEN, NULL, crypt->priv); >> - erq->length = (len >= 0 ? len : 0); >> + if (len > U16_MAX) >> + netdev_err(ieee->dev, "Too long key returned.\n"); > > Just delete the check if it can't happen or handle the error properly. > Never printed messages can be annoying. Static checkers assume all > conditions can happen so never true conditions are confusing. It wastes > RAM. Ok, will do, thanks. Regards, Mateusz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/