Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933138AbbELUni (ORCPT ); Tue, 12 May 2015 16:43:38 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:33753 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932611AbbELUnW (ORCPT ); Tue, 12 May 2015 16:43:22 -0400 Message-ID: <555265E6.4000400@gmail.com> Date: Tue, 12 May 2015 22:43:18 +0200 From: Mateusz Kulikowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Sudip Mukherjee CC: gregkh@linuxfoundation.org, dan.carpenter@oracle.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 07/33] staging: rtl8192e: Replace RTLLIB_DEBUG(DL_ERR) with netdev_*() References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com> <1431206361-13736-8-git-send-email-mateusz.kulikowski@gmail.com> <20150510075339.GB20096@sudip-PC> In-Reply-To: <20150510075339.GB20096@sudip-PC> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 923 Lines: 24 On 10.05.2015 09:53, Sudip Mukherjee wrote: > On Sat, May 09, 2015 at 11:18:55PM +0200, Mateusz Kulikowski wrote: >> Replace all RTLLIB_DEBUG(RTLLIB_DL_ERR, *) calls with netdev_err() >> for errors that really should be reported to user. >> Use netdev_warn() for the rest. >> Rephrase some of the messages to make them more readable/compact. > checkpatch is saying : > CHECK: Alignment should match open parenthesis > #332: FILE: drivers/staging/rtl8192e/rtl819x_TSProc.c:82: > + netdev_warn(ieee->dev, > + "%s(): Rx Reorder struct buffer full\n", > That's clearly a typo - thanks - will fix it - checkpatch didn't noticed that in non-strict mode. Regards, Mateusz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/