Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753920AbbELUqw (ORCPT ); Tue, 12 May 2015 16:46:52 -0400 Received: from mail-lb0-f169.google.com ([209.85.217.169]:33052 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753797AbbELUqs (ORCPT ); Tue, 12 May 2015 16:46:48 -0400 Message-ID: <555266B3.4010607@gmail.com> Date: Tue, 12 May 2015 22:46:43 +0200 From: Mateusz Kulikowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Dan Carpenter CC: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 04/33] staging: rtl8192e: Fix DEEP_INDENTATION warning in rtllib_parse_info_param() References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com> <1431206361-13736-5-git-send-email-mateusz.kulikowski@gmail.com> <20150511134840.GM14154@mwanda> In-Reply-To: <20150511134840.GM14154@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 977 Lines: 28 On 11.05.2015 15:48, Dan Carpenter wrote: > On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote: >> + if (info_element->len >= 4 && >> + info_element->data[0] == 0x00 && info_element->data[1] == 0x50 && >> + info_element->data[2] == 0xf2 && info_element->data[3] == 0x01) { > > > This if statement was actually easier to read in the original code: > > if (info_element->len >= 4 && > info_element->data[0] == 0x00 && > info_element->data[1] == 0x50 && > info_element->data[2] == 0xf2 && > info_element->data[3] == 0x01) { > > Your eye can immediately spot the bits which are different on each line > when they are lined up like that. You're right - will fix that. Regards, Mateusz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/