Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976AbbELUyq (ORCPT ); Tue, 12 May 2015 16:54:46 -0400 Received: from mga14.intel.com ([192.55.52.115]:31358 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753472AbbELUyn (ORCPT ); Tue, 12 May 2015 16:54:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,417,1427785200"; d="scan'208";a="492754530" User-Agent: Microsoft-MacOutlook/14.4.8.150116 Date: Tue, 12 May 2015 13:54:32 -0700 Subject: Re: [PATCH 1/5] selftests: Add futex functional tests From: Darren Hart To: Shuah Khan , Cyril Hrubis CC: , Linux Kernel Mailing List , John Stultz , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Davidlohr Bueso , KOSAKI Motohiro Message-ID: Thread-Topic: [PATCH 1/5] selftests: Add futex functional tests References: <5550FB2C.1000403@osg.samsung.com> <5551164E.5080409@osg.samsung.com> <55512B54.50304@osg.samsung.com> <55512B86.2040900@osg.samsung.com> <20150512100256.GA5122@rei.suse.de> <20150512200528.GA1336@rei> <55526544.90909@osg.samsung.com> In-Reply-To: <55526544.90909@osg.samsung.com> Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2238 Lines: 70 On 5/12/15, 1:40 PM, "Shuah Khan" wrote: >On 05/12/2015 02:15 PM, Darren Hart wrote: >> On 5/12/15, 1:05 PM, "Cyril Hrubis" wrote: >> >>> Hi! >>>>>> I'm happy to do that, but I would like to make sure I'm doing the >>>> right >>>>>> thing. >>>>> >>>>> The right thing here is to add -pthread to CFLAGS which sets both >>>>>flags >>>>> for preprocessor and linker (see man gcc). >>>> >>>> Hi Cyril, >>>> >>>> Thanks. I read that, and mentioned it, but my concern with -pthread in >>>> the >>>> CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I >>>> understand we have a number of gcc-isms in our build - but do we want >>>>to >>>> add more? >>>> >>>> I'm also struggling to find any kind of prescribed documentation on >>>>this >>>> beyond the short blurb in the gcc man page which describes what this >>>> option does, but not when to use it. I'll need something concrete to >>>> justify changes to testcase Makefiles to Shuah. >>> >>> Sorry to mislead you with the pointing at gcc man page. >>> >>> It is a Linux standard. Have a look at pthreads manual page: >>> http://man7.org/linux/man-pages/man7/pthreads.7.html >>> >>> "On Linux, programs that use the Pthreads API should be compiled using >>> cc -pthread." >>> >>> Or any pthread_foo() manual page that starts with: >>> >>> "Compile and link with -pthread." >>> >>> The portable way i.e. POSIX would be getting compiler flags with >>>getconf >>> but as this is a Linux kernel testsuite I would not bother with that. >>> Hmm, and it looks like this is not implemented on Linux anyway. >> >> Thanks Cyril, that's perfect. >> >> I'll roll my latest example patch adding -pthread to LDFLAGS and CFLAGS >> into the initial patch and resubmit the patch series as v4. >> > >Daren, > >While you are generating new version, could you also please add >.gitignore for the futex binaries, so they get ignored by git. Will do. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/