Message-ID: <55526A38.4040709@gmail.com>
Date: Tue, 12 May 2015 23:01:44 +0200
From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
CC: gregkh@linuxfoundation.org, dan.carpenter@oracle.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 04/33] staging: rtl8192e: Fix DEEP_INDENTATION warning
 in rtllib_parse_info_param()
References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com> <1431206361-13736-5-git-send-email-mateusz.kulikowski@gmail.com> <20150510074910.GA20096@sudip-PC>
In-Reply-To: <20150510074910.GA20096@sudip-PC>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1088
Lines: 30

On 10.05.2015 09:49, Sudip Mukherjee wrote:
> On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
>> Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
>> Code was not altered significantly, therefore in some places it generates
>> LONG_LINE checkpatch.pl warnings.
> apart from long line it is also giving warnings for:

You're running checkpatch --strict right?

> 1) multiple blank lines
> 2) Blank lines aren't necessary before a close brace
> 3) spaces preferred around that '+'

I will fix them (as they're pretty straightforward), and will 
probably do --strict checks for my patches in future;

I will not fix more complex checks in such cases, because patch like this
was supposed to simplify function (i.e. split it) - without changing 
it's code too much.

Is it ok with you?

Regards,
Mateusz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/