Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933707AbbELVVS (ORCPT ); Tue, 12 May 2015 17:21:18 -0400 Received: from lists.s-osg.org ([54.187.51.154]:55099 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933141AbbELVVO (ORCPT ); Tue, 12 May 2015 17:21:14 -0400 Message-ID: <55526EC8.30707@osg.samsung.com> Date: Tue, 12 May 2015 15:21:12 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Darren Hart , Cyril Hrubis CC: linux-api@vger.kernel.org, Linux Kernel Mailing List , John Stultz , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Davidlohr Bueso , KOSAKI Motohiro Subject: Re: [PATCH 1/5] selftests: Add futex functional tests References: <5550FB2C.1000403@osg.samsung.com> <5551164E.5080409@osg.samsung.com> <55512B54.50304@osg.samsung.com> <55512B86.2040900@osg.samsung.com> <20150512100256.GA5122@rei.suse.de> <20150512200528.GA1336@rei> <55526544.90909@osg.samsung.com> <55526DF1.1020103@osg.samsung.com> In-Reply-To: <55526DF1.1020103@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2957 Lines: 86 On 05/12/2015 03:17 PM, Shuah Khan wrote: > On 05/12/2015 02:54 PM, Darren Hart wrote: >> On 5/12/15, 1:40 PM, "Shuah Khan" wrote: >> >>> On 05/12/2015 02:15 PM, Darren Hart wrote: >>>> On 5/12/15, 1:05 PM, "Cyril Hrubis" wrote: >>>> >>>>> Hi! >>>>>>>> I'm happy to do that, but I would like to make sure I'm doing the >>>>>> right >>>>>>>> thing. >>>>>>> >>>>>>> The right thing here is to add -pthread to CFLAGS which sets both >>>>>>> flags >>>>>>> for preprocessor and linker (see man gcc). >>>>>> >>>>>> Hi Cyril, >>>>>> >>>>>> Thanks. I read that, and mentioned it, but my concern with -pthread in >>>>>> the >>>>>> CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I >>>>>> understand we have a number of gcc-isms in our build - but do we want >>>>>> to >>>>>> add more? >>>>>> >>>>>> I'm also struggling to find any kind of prescribed documentation on >>>>>> this >>>>>> beyond the short blurb in the gcc man page which describes what this >>>>>> option does, but not when to use it. I'll need something concrete to >>>>>> justify changes to testcase Makefiles to Shuah. >>>>> >>>>> Sorry to mislead you with the pointing at gcc man page. >>>>> >>>>> It is a Linux standard. Have a look at pthreads manual page: >>>>> http://man7.org/linux/man-pages/man7/pthreads.7.html >>>>> >>>>> "On Linux, programs that use the Pthreads API should be compiled using >>>>> cc -pthread." >>>>> >>>>> Or any pthread_foo() manual page that starts with: >>>>> >>>>> "Compile and link with -pthread." >>>>> >>>>> The portable way i.e. POSIX would be getting compiler flags with >>>>> getconf >>>>> but as this is a Linux kernel testsuite I would not bother with that. >>>>> Hmm, and it looks like this is not implemented on Linux anyway. >>>> >>>> Thanks Cyril, that's perfect. >>>> >>>> I'll roll my latest example patch adding -pthread to LDFLAGS and CFLAGS >>>> into the initial patch and resubmit the patch series as v4. >>>> >>> >>> Daren, >>> >>> While you are generating new version, could you also please add >>> .gitignore for the futex binaries, so they get ignored by git. >> >> Will do. >> > > Daren, > > Do you plan to add futex test install support in a later patch > series? When you sent this patch series, install support was > work in progress. 4.1 has the kselftest install feature. > > Feel free to defer it for a later patch series if you like. Would > be good to get the futex install support into 4.2 if it is possible. > I am blind. Never mind. futex tests are installed. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/