Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934153AbbELV7p (ORCPT ); Tue, 12 May 2015 17:59:45 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:35475 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933733AbbELV7Q (ORCPT ); Tue, 12 May 2015 17:59:16 -0400 From: tyler.baker@linaro.org To: Shuah Khan Cc: Andy Lutomirski , Kevin Hilman , John Stultz , Darren Hart , Michael Ellerman , David Herrmann , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Tyler Baker Subject: [PATCH 1/2] selftests/lib.mk: fix INSTALL_RULE Date: Tue, 12 May 2015 14:59:06 -0700 Message-Id: <1431467947-29847-2-git-send-email-tyler.baker@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1431467947-29847-1-git-send-email-tyler.baker@linaro.org> References: <1431467947-29847-1-git-send-email-tyler.baker@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1415 Lines: 40 From: Tyler Baker This patch fixes the INSTALL_RULE to gracefully handle the case where TEST_PROGS and TEST_PROGS_EXTENDED and TEST_FILES are not set. In this case, install is called without any SOURCE arguments causing make install to fail. The proposed fix is to loop over the items in these variables and only call install if there is a test artifact present. Signed-off-by: Tyler Baker --- tools/testing/selftests/lib.mk | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk index ee412ba..89dd785f 100644 --- a/tools/testing/selftests/lib.mk +++ b/tools/testing/selftests/lib.mk @@ -13,10 +13,12 @@ run_tests: all define INSTALL_RULE mkdir -p $(INSTALL_PATH) - @for TEST_DIR in $(TEST_DIRS); do\ + @for TEST_DIR in $(TEST_DIRS); do \ cp -r $$TEST_DIR $(INSTALL_PATH); \ done; - install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) + @for ARTIFACT in $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES); do \ + install -t $(INSTALL_PATH) $$ARTIFACT; \ + done; endef install: all -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/