Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964890AbbELXXg (ORCPT ); Tue, 12 May 2015 19:23:36 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:40693 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933666AbbELXXe (ORCPT ); Tue, 12 May 2015 19:23:34 -0400 Date: Wed, 13 May 2015 00:23:22 +0100 From: Russell King - ARM Linux To: Antoine Tenart Cc: sebastian.hesselbarth@gmail.com, zmxu@marvell.com, jszhang@marvell.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: berlin: add CPU hotplug support Message-ID: <20150512232322.GR2067@n2100.arm.linux.org.uk> References: <1431440186-14075-1-git-send-email-antoine.tenart@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431440186-14075-1-git-send-email-antoine.tenart@free-electrons.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1914 Lines: 63 On Tue, May 12, 2015 at 04:16:26PM +0200, Antoine Tenart wrote: > Adds CPU hotplug support for Berlin SoCs (currently BG2 and BG2Q). The > CPUs are put in WFI after disabling the coherency. > > Signed-off-by: Antoine Tenart > --- > arch/arm/mach-berlin/platsmp.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/mach-berlin/platsmp.c b/arch/arm/mach-berlin/platsmp.c > index 702e7982015a..d9c62057be76 100644 > --- a/arch/arm/mach-berlin/platsmp.c > +++ b/arch/arm/mach-berlin/platsmp.c > @@ -14,6 +14,7 @@ > #include > > #include > +#include I don't see anything being added by this patch which would need this include. > #include > #include > > @@ -92,8 +93,20 @@ unmap_scu: > iounmap(scu_base); > } > > +#ifdef CONFIG_HOTPLUG_CPU > +static void berlin_cpu_die(unsigned int cpu) > +{ > + v7_exit_coherency_flush(louis); > + while (1) > + cpu_do_idle(); > +} > +#endif > + > static struct smp_operations berlin_smp_ops __initdata = { > .smp_prepare_cpus = berlin_smp_prepare_cpus, > .smp_boot_secondary = berlin_boot_secondary, > +#ifdef CONFIG_HOTPLUG_CPU > + .cpu_die = berlin_cpu_die, > +#endif > }; > CPU_METHOD_OF_DECLARE(berlin_smp, "marvell,berlin-smp", &berlin_smp_ops); > -- > 2.4.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/