Date: Wed, 13 May 2015 09:35:36 +1000
From: NeilBrown <neilb@suse.de>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: NeilBrown <neil@brown.name>, Mark Rutland <mark.rutland@arm.com>,
        One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
        Peter Hurley <peter@hurleysoftware.com>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sebastian Reichel <sre@kernel.org>,
        Rob Herring <robherring2@gmail.com>, Pavel Machek <pavel@ucw.cz>,
        Grant Likely <grant.likely@linaro.org>, Jiri Slaby <jslaby@suse.cz>,
        GTA04 owners <gta04-owner@goldelico.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] TTY: add support for uart_slave devices.
Message-ID: <20150513093536.7a1d4a13@notabene.brown>
In-Reply-To: <1431419461.2398.132.camel@x220>
References: <20150511013540.5709.93626.stgit@notabene.brown>
	<20150511015614.5709.16746.stgit@notabene.brown>
	<1431419461.2398.132.camel@x220>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 boundary="Sig_/3KVj_YVTUp/k9H5jwBFe03A"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2591
Lines: 71

--Sig_/3KVj_YVTUp/k9H5jwBFe03A
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Tue, 12 May 2015 10:31:01 +0200 Paul Bolle <pebolle@tiscali.nl> wrote:

> Just a nit: a license mismatch.
>=20
> On Mon, 2015-05-11 at 11:56 +1000, NeilBrown wrote:
> > --- /dev/null
> > +++ b/drivers/tty/serial/slave/uart_slave_core.c
>=20
> > + *    This program is free software; you can redistribute it and/or mo=
dify
> > + *   it under the terms of the GNU General Public License as published=
 by
> > + *   the Free Software Foundation; either version 2 of the License, or
> > + *   (at your option) any later version.
> > + *
> > + *    This program is distributed in the hope that it will be useful,
> > + *   but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + *   GNU General Public License for more details.
>=20
> This states the license is GPL v2 or later.
>=20
> > +MODULE_LICENSE("GPL v2");
>=20
> And, according to include/linux/module.h, this states the license is
> just GPL v2. So I think either the comment at the top of this file or
> the license ident used in the MODULE_LICENSE() macro needs to change.
>=20
> Thanks,
>=20
>=20
> Paul Bolle
>=20

Thanks.  I've modified the comment to be explicit that only 'version 2' is
appropriate.

NeilBrown

--Sig_/3KVj_YVTUp/k9H5jwBFe03A
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIVAwUBVVKOSDnsnt1WYoG5AQKo/A/9GXaSmk4CY2t/fpX6aAlXdHHk7pmIb7gj
2QLS1IBzQVS6+h57TNpqntGmLgLiKRwePGR3JP2vNhpaCmh6APSxWEWnrvO2uJKy
j4zj5dSVEZNI4Pk25JA/8jKC075ZZZ6JqawTrp1OtdsciQm79471zzTZr+SMWU6a
5wd7L6L+jAwZXhn20T2x6lrNePhxr6/D2aFlH19Q92qfPHnd14VR/qeuJYp6VfXl
eOQFcuUDmw0U3GKDmoXwKgI27JTc4gVwMT8YjAtDLTDUoDUEPjV2FhOtfMUZAnmX
8gnUiioKHL3zvOZ5Zl2/MQ+l1SZjOrqHcMdKucuUG12NdvC+m3t0WaAYRMPXEbJi
utSsklUzQm2Xk0PehXjLwACxWe9ZLOnu37NGqukDgXIDpsSmoGy8tqxsdiaStmPG
XC7xO4sVpavnlPVs+0+E+GyFvTDs5OnjO4iMgdLJD5Ue723HCyqfK/vX/Lc0QBUG
SmxLWM4kxiXu55XryB3WUNv7ufbAGj+PBjHRn4zf0qnHb8pLEz84Eupl8he/3dzJ
Voo4QeG8wXaxLqRcMWxNI9ShuwupcU6tiUrl3IelzlIGHVVqLEK1oXsS5KAlEEIP
7yvJLAZ7aVxPelWNEEn9+Ki7zy/Z5D1QcKVPY7eCsm2O8kfagez8hE7bFU8dx3Jg
nqnawEezr9w=
=u8Ae
-----END PGP SIGNATURE-----

--Sig_/3KVj_YVTUp/k9H5jwBFe03A--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/