Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934241AbbEMAjX (ORCPT ); Tue, 12 May 2015 20:39:23 -0400 Received: from mailout.micron.com ([137.201.242.129]:17148 "EHLO mailout.micron.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934108AbbEMAjV (ORCPT ); Tue, 12 May 2015 20:39:21 -0400 Subject: Re: [PATCH 8/9] mtip32xx: abort secure erase operation if the device is mounted To: Jens Axboe References: <55513388.9030600@micron.com> <55522056.9050102@kernel.dk> CC: , Sam Bradshaw , Selvan Mani From: Asai Thambi SP Message-ID: <55529D36.10703@micron.com> Date: Tue, 12 May 2015 17:39:18 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <55522056.9050102@kernel.dk> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-TM-AS-Product-Ver: SMEX-11.0.0.4179-7.500.1018-21540.002 X-TM-AS-Result: No--12.885300-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MT-CheckInternalSenderRule: True Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1665 Lines: 41 On 5/12/2015 8:46 AM, Jens Axboe wrote: > On 05/11/2015 06:56 PM, Asai Thambi SP wrote: >> Signed-off-by: Sam Bradshaw >> Signed-off-by: Asai Thambi S P >> --- >> drivers/block/mtip32xx/mtip32xx.c | 12 ++++++++++++ >> 1 files changed, 12 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c >> index 0b223e3..f8c12e1 100644 >> --- a/drivers/block/mtip32xx/mtip32xx.c >> +++ b/drivers/block/mtip32xx/mtip32xx.c >> @@ -2147,6 +2147,18 @@ static int exec_drive_taskfile(struct driver_data *dd, >> fis.lba_hi, >> fis.device); >> >> + /* Check for secure erase while fs mounted */ >> + if ((fis.command == ATA_CMD_SEC_ERASE_PREP) || >> + (fis.command == ATA_CMD_SEC_ERASE_UNIT) || >> + (fis.command == 0xFC && fis.features == 0x12)) { >> + if (dd->bdev && dd->bdev->bd_holders > 0) { >> + dev_warn(&dd->pdev->dev, "Drive erase aborted due to non-zero refcount (%d)\n", >> + dd->bdev->bd_holders); >> + err = -ERESTARTSYS; >> + goto abort; >> + } >> + } > > I don't like this. If you want to do something like this, why not claim before these commands and unclaim after? If the claim fails, fail the command. > Not aware of bd_claim(). Thanks for the input. I will look into that. -- Regards, Asai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/