Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965192AbbEMA4I (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 May 2015 20:56:08 -0400
Received: from blu004-omc1s6.hotmail.com ([65.55.116.17]:60325 "EHLO
	BLU004-OMC1S6.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965034AbbEMA4F (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 May 2015 20:56:05 -0400
X-TMN: [LXjtF7v87CO7Dc0ozNzR3whNHS17Nl74]
X-Originating-Email: [xili_gchen_5257@hotmail.com]
Message-ID: <BLU437-SMTP63A0F14D55020B3B3489E4B9D90@phx.gbl>
Date: Wed, 13 May 2015 08:55:54 +0800
From: Chen Gang <xili_gchen_5257@hotmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0
MIME-Version: 1.0
To: Dave Jones <davej@codemonkey.org.uk>, Michael Cree <mcree@orcon.net.nz>,
        rth@twiddle.net, ink@jurassic.park.msu.ru,
        "mattst88@gmail.com" <mattst88@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-alpha@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] alpha: Wire up missing syscalls
References: <BLU436-SMTP115284EEDC94CD99F399465B9DD0@phx.gbl> <20150512085952.GC5711@tower> <20150512142942.GA12264@codemonkey.org.uk>
In-Reply-To: <20150512142942.GA12264@codemonkey.org.uk>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 13 May 2015 00:56:02.0912 (UTC) FILETIME=[95B42600:01D08D17]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1763
Lines: 42

On 05/12/2015 10:29 PM, Dave Jones wrote:
> On Tue, May 12, 2015 at 08:59:52PM +1200, Michael Cree wrote:
>  > On Sun, May 10, 2015 at 02:33:36AM +0800, Chen Gang wrote:
>  > > The related warnings:
>  > > 
>  > >     CALL    scripts/checksyscalls.sh
>  > >   <stdin>:1238:2: warning: #warning syscall seccomp not implemented [-Wcpp]
>  > >   <stdin>:1241:2: warning: #warning syscall getrandom not implemented [-Wcpp]
>  > >   <stdin>:1244:2: warning: #warning syscall memfd_create not implemented [-Wcpp]
>  > >   <stdin>:1247:2: warning: #warning syscall bpf not implemented [-Wcpp]
>  > >   <stdin>:1250:2: warning: #warning syscall execveat not implemented [-Wcpp]
>  > 
>  > Chen: Have you tested the syscalls you have wired up?
>  > 
>  > I have a suspicion that more is required to wire up the seccomp
>  > syscall.
> 
> likewise sys_bpf judging by the absence of bpf_int_jit_compile and friends in arch/alpha
> The weak symbols mean it probably compiles/links, but it doesn't actually do
> anything, and now instead of -ENOSYS, anyone trying to actually use that syscall
> on alpha will get weird results.
> 
> Shutting up warnings like this strikes me as the wrong thing to do.
> 

It sounds reasonable. For me, we need to wire up implemented syscalls,
and still left the unimplemented syscalls as building warnings.

If no any additional reply, I shall try to send patch v2 for it within
this week (2015-05-17).


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/