Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934400AbbEMDTP (ORCPT ); Tue, 12 May 2015 23:19:15 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:49122 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934004AbbEMDTL (ORCPT ); Tue, 12 May 2015 23:19:11 -0400 Date: Tue, 12 May 2015 23:19:09 -0400 (EDT) Message-Id: <20150512.231909.896139778564783277.davem@davemloft.net> To: niklas.cassel@axis.com Cc: f.fainelli@gmail.com, festevam@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, johan@kernel.org, niklass@axis.com, stable@vger.kernel.org Subject: Re: [PATCH v5] net: phy: micrel: Fix regression in kszphy_probe From: David Miller In-Reply-To: <1431416594-7758-1-git-send-email-niklass@axis.com> References: <1431416594-7758-1-git-send-email-niklass@axis.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 12 May 2015 20:19:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 26 From: Niklas Cassel Date: Tue, 12 May 2015 09:43:14 +0200 > Don't do clock-mode-select if clk == NULL, > since when building without CONFIG_HAVE_CLK, > clk_get returns NULL and clk_get_rate returns 0. > > Doing clock-mode-select in this cause causes kszphy_probe to > return -EINVAL and thus prevents the device from being probed. > > The original code (before regression) would return 0 > when building without CONFIG_HAVE_CLK. > > Cc: stable # 3.18+ > Fixes: 1fadee0c3645 ("net/phy: micrel: Add clock support for > KSZ8021/KSZ8031") > Reviewed-by: Fabio Estevam > Reviewed-by: Johan Hovold > Signed-off-by: Niklas Cassel Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/