Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751367AbbEMEqF (ORCPT ); Wed, 13 May 2015 00:46:05 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:34962 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbbEMEqB (ORCPT ); Wed, 13 May 2015 00:46:01 -0400 Date: Wed, 13 May 2015 10:15:50 +0530 From: Sudip Mukherjee To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, dan.carpenter@oracle.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 04/33] staging: rtl8192e: Fix DEEP_INDENTATION warning in rtllib_parse_info_param() Message-ID: <20150513044550.GA3428@sudip-PC> References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com> <1431206361-13736-5-git-send-email-mateusz.kulikowski@gmail.com> <20150510074910.GA20096@sudip-PC> <55526A38.4040709@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55526A38.4040709@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 35 On Tue, May 12, 2015 at 11:01:44PM +0200, Mateusz Kulikowski wrote: > On 10.05.2015 09:49, Sudip Mukherjee wrote: > > On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote: > > You're running checkpatch --strict right? > > > 1) multiple blank lines > > 2) Blank lines aren't necessary before a close brace > > 3) spaces preferred around that '+' > > I will fix them (as they're pretty straightforward), and will > probably do --strict checks for my patches in future; I think --strict is the suggested way of checking. And if i remember correctly it was once discussed to make --strict the default mode, but I think that was never done. > > I will not fix more complex checks in such cases, because patch like this > was supposed to simplify function (i.e. split it) - without changing > it's code too much. > > Is it ok with you? ofcourse, checkpatch also complained about many other things, but they will need separate patch to correct. regards sudip > > Regards, > Mateusz > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/