Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbbEMFlK (ORCPT ); Wed, 13 May 2015 01:41:10 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:59198 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751065AbbEMFlG (ORCPT ); Wed, 13 May 2015 01:41:06 -0400 Message-ID: <1431495663.26897.47.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH 01/12] target: Convert se_node_acl->device_list[] to RCU hlist From: "Nicholas A. Bellinger" To: Christoph Hellwig Cc: Andy Grover , "Nicholas A. Bellinger" , target-devel , linux-scsi , linux-kernel , Hannes Reinecke , Sagi Grimberg Date: Tue, 12 May 2015 22:41:03 -0700 In-Reply-To: <20150513053233.GA20663@lst.de> References: <1431422736-29125-1-git-send-email-nab@daterainc.com> <1431422736-29125-2-git-send-email-nab@daterainc.com> <5552696F.8080904@redhat.com> <1431493731.26897.35.camel@haakon3.risingtidesystems.com> <20150513053233.GA20663@lst.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1718 Lines: 34 On Wed, 2015-05-13 at 07:32 +0200, Christoph Hellwig wrote: > On Tue, May 12, 2015 at 10:08:51PM -0700, Nicholas A. Bellinger wrote: > > The series is bisectable. With patch #1 in place ->device_list[] is > > still kzalloc()'ed, but new RCU pointer assignments are made into > > lun_entry_hlist[]. > > > > Squashing the RCU reader paths (#2-6) for merge is OK, but it's still > > nice to break up reader / updater changes into separate patches. > > Having the full data structure switch over in one patch really makes > reviewing and understning the change a lot easier. But changes to > say move to a mutex should indeed stay separate. So patches 1-6 > really should be mostly one. Well, was thinking 1-6 is too big for one patch, but I guess it's not so bad: drivers/target/target_core_device.c | 268 +++++++++++++++++++++++++++--------------------- drivers/target/target_core_fabric_configfs.c | 35 ++++--- drivers/target/target_core_internal.h | 1 + drivers/target/target_core_pr.c | 1 + drivers/target/target_core_pscsi.c | 17 ++- drivers/target/target_core_spc.c | 27 +++-- drivers/target/target_core_stat.c | 180 ++++++++++++++++---------------- drivers/target/target_core_tpg.c | 59 +++-------- drivers/target/target_core_ua.c | 51 ++++++--- include/target/target_core_base.h | 8 +- 10 files changed, 350 insertions(+), 297 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/