Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752797AbbEMFtS (ORCPT ); Wed, 13 May 2015 01:49:18 -0400 Received: from verein.lst.de ([213.95.11.211]:48272 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbbEMFtO (ORCPT ); Wed, 13 May 2015 01:49:14 -0400 Date: Wed, 13 May 2015 07:49:12 +0200 From: Christoph Hellwig To: "Nicholas A. Bellinger" Cc: Andy Grover , "Nicholas A. Bellinger" , target-devel , linux-scsi , linux-kernel , Hannes Reinecke , Christoph Hellwig , Sagi Grimberg Subject: Re: [PATCH 03/12] target/configfs: Convert mappedlun + SCSI MIBs to RCU reader Message-ID: <20150513054912.GC20825@lst.de> References: <1431422736-29125-1-git-send-email-nab@daterainc.com> <1431422736-29125-4-git-send-email-nab@daterainc.com> <5552697B.8050008@redhat.com> <1431493763.26897.36.camel@haakon3.risingtidesystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431493763.26897.36.camel@haakon3.risingtidesystems.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 16 On Tue, May 12, 2015 at 10:09:23PM -0700, Nicholas A. Bellinger wrote: > > Why do we still need TRANSPORT_LUNFLAGS_INITIATOR_ACCESS? Isn't deve > > being not-NULL enough? > > > > Yep, I think this can go as well. Dropping now. Also might be worth to add a helper that has the ->se_lun_acl check in one place and documents why these callers want a dev_entry with a proper ACL. Also I think the ->se_lun checks should not be needed here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/