Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753871AbbEMHf0 (ORCPT ); Wed, 13 May 2015 03:35:26 -0400 Received: from down.free-electrons.com ([37.187.137.238]:50568 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751762AbbEMHfR (ORCPT ); Wed, 13 May 2015 03:35:17 -0400 Date: Wed, 13 May 2015 09:35:13 +0200 From: Antoine Tenart To: Russell King - ARM Linux Cc: Antoine Tenart , sebastian.hesselbarth@gmail.com, zmxu@marvell.com, jszhang@marvell.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: berlin: add CPU hotplug support Message-ID: <20150513073513.GE32171@kwain> References: <1431440186-14075-1-git-send-email-antoine.tenart@free-electrons.com> <20150512232322.GR2067@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150512232322.GR2067@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1557 Lines: 48 On Wed, May 13, 2015 at 12:23:22AM +0100, Russell King - ARM Linux wrote: > On Tue, May 12, 2015 at 04:16:26PM +0200, Antoine Tenart wrote: > > Adds CPU hotplug support for Berlin SoCs (currently BG2 and BG2Q). The > > CPUs are put in WFI after disabling the coherency. > > > > Signed-off-by: Antoine Tenart > > --- > > arch/arm/mach-berlin/platsmp.c | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/arch/arm/mach-berlin/platsmp.c b/arch/arm/mach-berlin/platsmp.c > > index 702e7982015a..d9c62057be76 100644 > > --- a/arch/arm/mach-berlin/platsmp.c > > +++ b/arch/arm/mach-berlin/platsmp.c > > @@ -14,6 +14,7 @@ > > #include > > > > #include > > +#include > > I don't see anything being added by this patch which would need this > include. v7_exit_coherency_flush(..) needs CR_C to be defined, which is done in asm/cp15.h. Is there a better way to get this defined here? > > > > +#ifdef CONFIG_HOTPLUG_CPU > > +static void berlin_cpu_die(unsigned int cpu) > > +{ > > + v7_exit_coherency_flush(louis); > > + while (1) > > + cpu_do_idle(); > > +} > > +#endif > > + Antoine -- Antoine T?nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/