Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 14 Feb 2001 09:55:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 14 Feb 2001 09:55:12 -0500 Received: from brutus.conectiva.com.br ([200.250.58.146]:4341 "HELO brinquedo.distro.conectiva") by vger.kernel.org with SMTP id ; Wed, 14 Feb 2001 09:55:03 -0500 Date: Wed, 14 Feb 2001 11:13:38 -0200 From: Arnaldo Carvalho de Melo To: Jeff Garzik Cc: Manfred Spraul , linux-kernel@vger.kernel.org Subject: Re: [PATCH] network driver updates Message-ID: <20010214111338.C7859@conectiva.com.br> Mail-Followup-To: Arnaldo Carvalho de Melo , Jeff Garzik , Manfred Spraul , linux-kernel@vger.kernel.org In-Reply-To: <3A8A7159.AF0E6180@colorfullife.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.14i In-Reply-To: ; from jgarzik@mandrakesoft.mandrakesoft.com on Wed, Feb 14, 2001 at 05:54:34AM -0600 X-Url: http://advogato.org/person/acme Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Feb 14, 2001 at 05:54:34AM -0600, Jeff Garzik escreveu: > On Wed, 14 Feb 2001, Manfred Spraul wrote: > > * dev->mem_start: NULL means "not command line configuration" 0xffffffff > > means "default". > > several drivers only check for NULL, not for 0xffffffff. > > netdev->mem_start is unsigned long... Should the test be for ~0 instead? > The value 0xFFFFFFFF seems wrong for 64-bit machines. I've added this to the Janitor's TODO List. http://bazar.conectiva.com.br/~acme/TODO - Arnaldo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/