Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933492AbbEMI1L (ORCPT ); Wed, 13 May 2015 04:27:11 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:32149 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754181AbbEMI1H (ORCPT ); Wed, 13 May 2015 04:27:07 -0400 Date: Wed, 13 May 2015 11:26:53 +0300 From: Dan Carpenter To: Mateusz Kulikowski Cc: Sudip Mukherjee , devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 04/33] staging: rtl8192e: Fix DEEP_INDENTATION warning in rtllib_parse_info_param() Message-ID: <20150513082653.GR14154@mwanda> References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com> <1431206361-13736-5-git-send-email-mateusz.kulikowski@gmail.com> <20150510074910.GA20096@sudip-PC> <55526A38.4040709@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55526A38.4040709@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 518 Lines: 13 Actually, to be honest, I would prefer if you moved things without changing it too much. I have a script to review "move code to a new function" patches but if everything moves and changes as well then it's confusing and I have to do it by hand. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/