Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754426AbbEMIqS (ORCPT ); Wed, 13 May 2015 04:46:18 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:41025 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbbEMIqP (ORCPT ); Wed, 13 May 2015 04:46:15 -0400 Message-ID: <1431506771.26897.78.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH 01/12] target: Convert se_node_acl->device_list[] to RCU hlist From: "Nicholas A. Bellinger" To: Christoph Hellwig Cc: "Nicholas A. Bellinger" , target-devel , linux-scsi , linux-kernel , Hannes Reinecke , Sagi Grimberg Date: Wed, 13 May 2015 01:46:11 -0700 In-Reply-To: <20150513063555.GA21770@lst.de> References: <1431422736-29125-1-git-send-email-nab@daterainc.com> <1431422736-29125-2-git-send-email-nab@daterainc.com> <20150513063555.GA21770@lst.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 694 Lines: 20 On Wed, 2015-05-13 at 08:35 +0200, Christoph Hellwig wrote: > Onemore comments from looking oer the RCU usage with all the patches > applied: > > In core_get_se_deve_from_rtpi we dereference lun->lun_sep, so > either struct se_port needs to be switched to kfree_rcu, > or we need to mirror the rtpi value into the se_lun. Updated to use a mirror lun->lun_rtpi, with the assignment from sep_rtpi occuring in core_dev_export() code. Thanks HCH. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/