Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754420AbbEMJmU (ORCPT ); Wed, 13 May 2015 05:42:20 -0400 Received: from mail-vn0-f51.google.com ([209.85.216.51]:38136 "EHLO mail-vn0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753843AbbEMJmR (ORCPT ); Wed, 13 May 2015 05:42:17 -0400 MIME-Version: 1.0 In-Reply-To: <5553125A.6090404@kernel.org> References: <1431351773-2031-1-git-send-email-k.kozlowski.k@gmail.com> <1431351773-2031-2-git-send-email-k.kozlowski.k@gmail.com> <5553125A.6090404@kernel.org> Date: Wed, 13 May 2015 18:42:16 +0900 Message-ID: Subject: Re: [PATCH v4 01/13] ARM: dts: Add labels to Exynos4 nodes From: =?UTF-8?Q?Krzysztof_Koz=C5=82owski?= To: Kukjin Kim Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2153 Lines: 64 2015-05-13 17:59 GMT+09:00 Kukjin Kim : > On 05/11/15 22:42, Krzysztof Kozlowski wrote: >> Add new labels to certain nodes so they could be easily referenced by >> Exynos4 board DTS files. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm/boot/dts/exynos4.dtsi | 22 +++++++++++----------- >> arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 6 +++--- >> arch/arm/boot/dts/exynos4210.dtsi | 6 +++--- >> arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 8 ++++---- >> arch/arm/boot/dts/exynos4x12.dtsi | 2 +- >> 5 files changed, 22 insertions(+), 22 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi >> index 1c74c1296ab7..0ec292d25b6e 100644 >> --- a/arch/arm/boot/dts/exynos4.dtsi >> +++ b/arch/arm/boot/dts/exynos4.dtsi > > [...] > >> diff --git a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi >> index a7c212891674..4704e7bb2628 100644 >> --- a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi >> +++ b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi >> @@ -15,7 +15,7 @@ >> */ >> >> / { >> - pinctrl@11400000 { >> + pinctrl_0: pinctrl@11400000 { >> gpa0: gpa0 { >> gpio-controller; >> #gpio-cells = <2>; >> @@ -421,7 +421,7 @@ >> }; >> }; >> >> - pinctrl@11000000 { >> + pinctrl_1: pinctrl@11000000 { >> gpj0: gpj0 { >> gpio-controller; >> #gpio-cells = <2>; >> @@ -822,7 +822,7 @@ >> }; >> }; >> >> - pinctrl@03860000 { >> + pinctrl_3: pinctrl@03860000 { > > Maybe, > + pinctrl_2: pinctrl@03860000 { ? Yes, you are right. Actually I made mistake here because in exynos4210.dtsi these labels are defined. I will fix it and re-spin. Thanks for feedback, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/