Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933849AbbEMJ4J (ORCPT ); Wed, 13 May 2015 05:56:09 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:36158 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933159AbbEMJ4F (ORCPT ); Wed, 13 May 2015 05:56:05 -0400 Message-ID: <55531FAF.2000704@gmail.com> Date: Wed, 13 May 2015 18:55:59 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Kukjin Kim CC: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 03/13] ARM: dts: exynos4: Use labels for overriding nodes in Exynos4210 Origen References: <1431351773-2031-1-git-send-email-k.kozlowski.k@gmail.com> <1431351773-2031-4-git-send-email-k.kozlowski.k@gmail.com> <55531536.4040608@kernel.org> In-Reply-To: <55531536.4040608@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1247 Lines: 37 W dniu 13.05.2015 o 18:11, Kukjin Kim pisze: > On 05/11/15 22:42, Krzysztof Kozlowski wrote: >> Usage of labels instead of full paths reduces possible mistakes when >> overriding nodes. >> > > In case of this changes, I have no objection. > But I can't see the 'codec' node you deleted in this patch? It is under label "mfc". This label was already defined in exynos4.dtsi before: >> +&mfc { >> + samsung,mfc-r = <0x43000000 0x800000>; >> + samsung,mfc-l = <0x51000000 0x800000>; >> + status = "okay"; >> +}; > > And if possible, can you please put the labels in alphabetically when > you create this patch again? so that we could find the labels easily... Yes, when I switched to the "label convention" I put them in alphabetical order. However I did not re-order other (existing) nodes. This makes some confusion but I wanted to limit the scope of this change and do only one thing - switch to "label convention". Do you want me to reorder alphabetically everything? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/