Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933887AbbEMKBu (ORCPT ); Wed, 13 May 2015 06:01:50 -0400 Received: from mail-vn0-f50.google.com ([209.85.216.50]:42809 "EHLO mail-vn0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418AbbEMKBq (ORCPT ); Wed, 13 May 2015 06:01:46 -0400 MIME-Version: 1.0 In-Reply-To: <55530F07.5080503@kernel.org> References: <1431487072-17567-1-git-send-email-k.kozlowski@samsung.com> <55530F07.5080503@kernel.org> Date: Wed, 13 May 2015 19:01:45 +0900 X-Google-Sender-Auth: fW86IL59EQYb58DVurBP3zwPLCQ Message-ID: Subject: Re: [PATCH] ARM: EXYNOS: Fix dereference of ERR_PTR returned byof_genpd_get_from_provider From: Krzysztof Kozlowski To: Kukjin Kim Cc: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1578 Lines: 38 2015-05-13 17:44 GMT+09:00 Kukjin Kim : > On 05/13/15 12:17, Krzysztof Kozlowski wrote: >> ERR_PTR was dereferenced during sub domain parsing, if parent domain >> could not be obtained (because of invalid phandle or deferred >> registration of parent domain). >> >> The Exynos power domain code checked whether >> of_genpd_get_from_provider() returned NULL and in that case it skipped >> that power domain node. However this function returns ERR_PTR or valid >> pointer, not NULL. >> >> Signed-off-by: Krzysztof Kozlowski >> Cc: > > Maybe [4.0+]? but as you mentioned this patch has a dependency with Tag fixes with commit ID is sufficient for stable backporting. > Patch "ARM: EXYNOS: Add missing of_node_put() when parsing power domain" > and it means this cannot be applied into stable tree... > > So I'll apply this patch firstly then please re-submit them I've missed > before based on samsung tree. I think, it would be better... > >> Fixes: 0f7807518fe1 ("ARM: EXYNOS: add support for sub-power domains") I will get an notification when this patch won't apply to stable tree (like v4.0) because of conflicts. Then usually I fix/rebase the patch and send to the stable tree. So don't worry about this, I will handle the backport. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/