From: "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>
To: Lee Jones <lee.jones@linaro.org>
CC: Samuel Ortiz <sameo@linux.intel.com>, DT <devicetree@vger.kernel.org>,
        David Dajun Chen <david.chen@diasemi.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        INPUT <linux-input@vger.kernel.org>,
        "Ian Campbell" <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, LKML <linux-kernel@vger.kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, Pawel Moll <pawel.moll@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        "Support Opensource" <Support.Opensource@diasemi.com>
Subject: RE: [PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver
Thread-Topic: [PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver
Thread-Index: AQHQjLjQrMiheh8rr0CysaxPLpTCUJ15pqIAgAARIHA=
Date: Wed, 13 May 2015 10:47:21 +0000
Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B22A375@SW-EX-MBX02.diasemi.com>
References: <cover.1431437466.git.stwiss.opensource@diasemi.com>
 <81dec245f0d1a3a0713e6e2966d2278e422208f2.1431437466.git.stwiss.opensource@diasemi.com>
 <20150513103442.GG3394@x1>
In-Reply-To: <20150513103442.GG3394@x1>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1513
Lines: 44

On 13 May 2015 11:35 Lee Jones wrote:

> > From: Steve Twiss <stwiss.opensource@diasemi.com>
> >
> > Add MFD support for the DA9063 OnKey driver
> >
> > The function da9063_clear_fault_log() is added to mitigate the case of a
> > hardware power-cut after a long-long OnKey press. Although there is no
> > software intervention in this case (by definition) such a shutdown would
> > cause persistent information within the DA9063 FAULT_LOG that would be
> > available during the next device restart.
> >
> > Clearance of this persistent register must be completed after such a
> > hardware power-cut operation has happened so that the FAULT_LOG does not
> > continue with previous values. The clearance function has been added here
> > in the kernel driver because wiping the fault-log cannot be counted on
> > outside the Linux kernel.
> >
> >
> > Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
> >

[...]

> >  drivers/mfd/da9063-core.c        | 54
> ++++++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/da9063/pdata.h |  1 +
> >  2 files changed, 55 insertions(+)
> 
> I'll wait to see what Dmitry has to say before applying, but for my
> own reference:

Understood.
Thank you.

> Acked-by: Lee Jones <lee.jones@linaro.org>

Thanks for this Ack.
And for [PATCH V4 2/3] devicetree: Add bindings for DA9063 OnKey

Regards,
Steve

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?