Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754688AbbEML6l (ORCPT ); Wed, 13 May 2015 07:58:41 -0400 Received: from mail-ob0-f169.google.com ([209.85.214.169]:35617 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754539AbbEML6i (ORCPT ); Wed, 13 May 2015 07:58:38 -0400 MIME-Version: 1.0 In-Reply-To: References: <1426676484-21812-1-git-send-email-marc.zyngier@arm.com> <1426676484-21812-3-git-send-email-marc.zyngier@arm.com> Date: Wed, 13 May 2015 13:58:37 +0200 Message-ID: Subject: Re: [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state From: Linus Walleij To: Feng Kan Cc: Marc Zyngier , Abhijeet Dharmapurikar , Stephen Boyd , Phong Vo , Tin Huynh , Y Vo , Thomas Gleixner , Toan Le , Bjorn Andersson , Jason Cooper , Arnd Bergmann , linux-arm-msm , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , Alexandre Courbot Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 943 Lines: 23 On Wed, May 13, 2015 at 4:25 AM, Feng Kan wrote: > Marc: > > Sorry for top posting. It seems with GIC-400, the get_irqstate is not a reliable > way of accessing the GPIO status. In our case, the gpio interrupt status can > only be read correctly with the SPISR register. So it seems we have to go > back to the old way of mapping the SPISR portion of the GIC in our GPIO > driver. We wanted to ask you if that is acceptable since SPISR in not > standard in all GIC, perhaps we can treat it differently. As GPIO maintainer I am curious about what this is... Can you describe the scenario where your GPIO (!) driver needs to be poking around in the GIC SPISR? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/