Message-ID: <55534225.1050305@freescale.com>
Date: Wed, 13 May 2015 15:23:01 +0300
From: Purcareata Bogdan <b43198@freescale.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Bogdan Purcareata <bogdan.purcareata@freescale.com>,
        <linuxppc-dev@lists.ozlabs.org>, <scottwood@freescale.com>,
        <segher@kernel.crashing.org>, <benh@kernel.crashing.org>
CC: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc/mpic: Remove WHOAMI readback after EOI
References: <1427193823-14597-1-git-send-email-bogdan.purcareata@freescale.com>
In-Reply-To: <1427193823-14597-1-git-send-email-bogdan.purcareata@freescale.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2015 12:23:21.5809
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1406
Lines: 38

Ping?

On 24.03.2015 12:43, Bogdan Purcareata wrote:
> After previous discussions regarding the subject [1][2], there's no clear
> explanation or reason why the call was needed in the first place. The sensible
> argument is some sort of synchronization between the CPU and the MPIC, which
> hasn't been pointed out precisely and is no longer required (at least on BookE
> platforms).
>
> The benefit of this change is saving a MMIO trap per interrupt when running in a
> KVM guest.
>
> [1] https://patchwork.ozlabs.org/patch/429098/
> [2] https://patchwork.ozlabs.org/patch/433557/
>
> Signed-off-by: Bogdan Purcareata <bogdan.purcareata@freescale.com>
> ---
>   arch/powerpc/sysdev/mpic.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
> index bbfbbf2..045e72a9 100644
> --- a/arch/powerpc/sysdev/mpic.c
> +++ b/arch/powerpc/sysdev/mpic.c
> @@ -655,7 +655,6 @@ static inline struct mpic * mpic_from_irq_data(struct irq_data *d)
>   static inline void mpic_eoi(struct mpic *mpic)
>   {
>   	mpic_cpu_write(MPIC_INFO(CPU_EOI), 0);
> -	(void)mpic_cpu_read(MPIC_INFO(CPU_WHOAMI));
>   }
>
>   /*
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/