Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965023AbbEMM7G (ORCPT ); Wed, 13 May 2015 08:59:06 -0400 Received: from down.free-electrons.com ([37.187.137.238]:32901 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933335AbbEMM7A (ORCPT ); Wed, 13 May 2015 08:59:00 -0400 Date: Wed, 13 May 2015 14:58:58 +0200 From: Alexandre Belloni To: "Opensource [Steve Twiss]" Cc: Alessandro Zummo , LINUXKERNEL , RTCLINUX , DEVICETREE , David Dajun Chen , Dmitry Torokhov , Ian Campbell , Kumar Gala , LINUXINPUT , LINUXWATCHDOG , Lee Jones , Liam Girdwood , Mark Brown , Mark Rutland , Pawel Moll , Rob Herring , Samuel Ortiz , Support Opensource , Wim Van Sebroeck Subject: Re: [rtc-linux] [PATCH V1 3/6] rtc: da9062: DA9062 RTC driver Message-ID: <20150513125858.GX3338@piout.net> References: <860a3b6dc7f8dac95c0e36967f24551af8805f7b.1429280614.git.stwiss.opensource@diasemi.com> <20150510095838.GF3338@piout.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22A3F3@SW-EX-MBX02.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7014B22A3F3@SW-EX-MBX02.diasemi.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1776 Lines: 41 Hi, On 13/05/2015 at 12:31:36 +0000, Opensource [Steve Twiss] wrote : > Something similar is being discussed for the OnKey component of the DA9062. > https://lkml.org/lkml/2015/4/24/304 > > It is only the OnKey and RTC components that are similar to the DA9063 chip > and I was hoping to keep the 62 RTC separate in this case ... however it should > definitely be possible to re-use the DA9063 RTC driver if this is your requirement. > If this will block my submission of the DA9062 then I will drop the RTC from my > next patch set and try to re-work the existing 63 RTC driver accordingly. > > I think this sort of thing has been done before: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/rtc/rtc-pm8xxx.c > ... at first glance -- it seems to support that sort of thing. > Isn't that exactly the point of using the MFD infrastructure? It allows to reuse existing drivers even when the IP is part of a different chip. The RTC inside the da9062 and the da9063 are obviously the same so there is no point in duplicating the driver. I'm guessing using da9063-rtc instead of da9062-rtc is just working fine. > I guess it would be possible to rename the da9063-rtc to something more sensible like > da9xxx-rtc.c if this goes ahead? > Sure, that can be done but this means that the module name will change. if you feel that your current users can cope with that, I'm fine with it. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/