Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965104AbbEMNBo (ORCPT ); Wed, 13 May 2015 09:01:44 -0400 Received: from snt004-omc3s3.hotmail.com ([65.55.90.142]:58409 "EHLO SNT004-OMC3S3.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933410AbbEMNBl convert rfc822-to-8bit (ORCPT ); Wed, 13 May 2015 09:01:41 -0400 X-TMN: [XM8PYiokEK2KbFdBu5GNTXuq57LWZGvs] X-Originating-Email: [indrakanti_ram@hotmail.com] Message-ID: From: ram kiran To: =?iso-8859-2?B?SmFrdWIgS2ljafFza2k=?= CC: "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jslaby@suse.cz" , "gregkh@linuxfoundation.org" , "indrakanti.ram@gmail.com" Subject: RE: [PATCH v2] sc16is7xx: spi interface is added Date: Wed, 13 May 2015 18:31:39 +0530 Importance: Normal In-Reply-To: <20150513142112.32fb6781@north> References: ,<20150513142112.32fb6781@north> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 X-OriginalArrivalTime: 13 May 2015 13:01:40.0352 (UTC) FILETIME=[F40A4800:01D08D7C] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3581 Lines: 104 > On Wed, 13 May 2015 16:27:58 +0530, ram.i hcltech wrote: >> spi interface for sc16is7xx is added along with Kconfig flag >> to enable spi or i2c, thus in a instance we can have either >> spi or i2c or both, in sync to the hw. >> >> Signed-off-by: ram.i hcltech >> --- >> >> Changes in v2: >> -Added seprate flags for i2c and spi >> -Added space in the comments lines >> -Added MODULE_ALIAS for spi interface >> --- >> drivers/tty/serial/Kconfig | 27 +++++++++++++++-- >> drivers/tty/serial/sc16is7xx.c | 69 +++++++++++++++++++++++++++++++++++++++++- >> 2 files changed, 92 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig >> index f8120c1..8c505b2 100644 >> --- a/drivers/tty/serial/Kconfig >> +++ b/drivers/tty/serial/Kconfig >> @@ -1181,13 +1181,34 @@ config SERIAL_SCCNXP_CONSOLE >> >> config SERIAL_SC16IS7XX >> tristate "SC16IS7xx serial support" >> - depends on I2C > > Please keep the dependency like this: > depends on I2C || SPI_MASTER > > (or SPI, I don't know what's the difference. SPI seems fine.) > The depends on is pushed to the interface selection... i think that would be better as it be collated accordingly. >> select SERIAL_CORE >> - select REGMAP_I2C if I2C >> help >> This selects support for SC16IS7xx serial ports. >> Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, >> - SC16IS760 and SC16IS762. >> + SC16IS760 and SC16IS762, over i2c or spi. >> + select at least one of the i2c or spi interface. > > I would phrase the help message like this: > > This selects support for SC16IS7xx serial ports. > Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, > SC16IS760 and SC16IS762. Select supported buses using options below. > Yeah a better one..will take it... >> +config SERIAL_SC16IS7XX_I2C >> + bool "SC16IS7xx for I2C interface" > > Please add "default y" to minimize oldconfig pain for those already > using the driver. > yes, missed this. >> + depends on SERIAL_SC16IS7XX=y > > Why =y? > >> + depends on I2C >> + select REGMAP_I2C if I2C >> + help >> + to enable i2c interface for SC16IS7XX, say Y, >> + Otherwise, for i2c say N. >> + this would make the driver to interface over SPI and I2C would >> + be diabled. > > I would phrase it simply like this: > > Enable SC16IS7xx driver on I2C bus. short description for the flags fails in checkpatch.pl and hence the text.. > >> +config SERIAL_SC16IS7XX_SPI >> + bool "SC16IS7xx for spi interface" >> + depends on SERIAL_SC16IS7XX >> + depends on SPI_MASTER > > Right now it is possible to select the driver without any bus-specific > option being set. I don't see an easy way to avoid this but please > make sure that there are no build failures/warnings in this scenario. > Yes, that being the reason, and for the driver to work, there should be any one the interfaces to be enabled by default. > You should also extend the binding information to include the new SPI > interface (Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt) > Yes, this needs to be updated, i think that shall be a separate patch... > > Thanks! > -- > To unsubscribe from this list: send the line "unsubscribe linux-serial" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/